Updated documentation for elb-load-balancing #267
+127
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhirajadhikary06
requested review from
quetzalliwrites and
remotesynth
as code owners
|
@remotesynth @quetzalliwrites @blkgrlcto Please have a check at the PR. |
|
@blkgrlcto please put this PR under review |
quetzalliwrites
added
documentation
|
Thank you for your contribution, @abhirajadhikary06! 🤝 We appreciate your patience as the team takes the time to review the many HacktoberFest PRs that came through! Also some folks were on holiday. |
| - Lambda Functions: Handle business logic (e.g., return "Hello 1"). | ||
| - VPC/Subnet: Provides network boundaries. | ||
|
|
||
|  |
There was a problem hiding this comment.
Wow @abhirajadhikary06, that's a neat diagram! Love it.
The only thing is that I would like all diagrams added to the docs be consistent in look/feel.
Let me ask the team their thoughts too :)
|
@blkgrlcto @remotesynth Hola team, quick Q about the diagrams. Since we want them to be consistent... how do we feel about asking all docs contributors to make all diagrams as Mermaid.JS syntax? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #219
I have added the required things in the documentation of elb-load-balancing:
curlchecks.Now all 6 sections are present perfectly.
[x]I agree to follow this project's Code of Conduct
Architecture Diagram that is added to the context:
